feat: allow complete channel list throttled reload on internet connection recovery #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
previously approved these changes
Oct 11, 2023
Co-authored-by: Oliver Lazoroski <oliver.lazoroski@gmail.com>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2123 +/- ##
===========================================
+ Coverage 83.21% 83.24% +0.03%
===========================================
Files 293 293
Lines 7013 7032 +19
Branches 1997 2003 +6
===========================================
+ Hits 5836 5854 +18
Misses 848 848
- Partials 329 330 +1
☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Oct 11, 2023
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
# [10.14.0](v10.13.1...v10.14.0) (2023-10-11) ### Features * allow complete channel list throttled reload on internet connection recovery ([#2123](#2123)) ([252cac3](252cac3))
|
🎉 This PR is included in version 10.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
# [11.0.0-rc.1](v10.13.1...v11.0.0-rc.1) (2023-10-12) ### Bug Fixes * **emoji-mart:** new reactions ([#1947](#1947)) ([2050708](2050708)) ### Features * allow complete channel list throttled reload on internet connection recovery ([#2123](#2123)) ([252cac3](252cac3)) ### BREAKING CHANGES * **emoji-mart:** `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/7a19e386aa3adcc5741a7f0d92bc816a1a424094/docusaurus/docs/React/release-guides/new-reactions.mdx) for more information
|
🎉 This PR is included in version 11.0.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to load the most recent updates to the ChannelList after the internet connection loss. The
StreamChatclient's recovery mechanism has the following shortcomings:On the other side, the SDK's recovery mechanism just reloads the channel list based on the filters, sort and options parameters originally provided to
ChannelListthrough props.This is an opt-in feature that has to be enabled as described in the documentation.
Currently it is not possible to load both the latest updates that would include new channels at the top and the originally loaded channels due to the fact that after re-querying the originally loaded channels we loose track of the next page for the channels pagination.